Address some native AoT warnings #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Address some native AoT warnings with .NET 8. The only remaining warning is from the usage of `ReflectionHelper.CallStaticMethod()`.
There was a problem hiding this comment.
Pull Request Overview
This PR addresses native AoT warnings in .NET 8 by implementing conditional compilation directives and runtime checks to handle features that are incompatible with native AoT compilation, particularly SQL instrumentation.
- Adds
RequiresUnreferencedCodeattribute toSqlClientInitializerto warn about trimming incompatibility - Refactors the static initializer array to use runtime checks for native AoT compatibility
- Optimizes various code patterns to use .NET-specific features where available
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/Grafana.OpenTelemetry.Base/Instrumentations/SqlClientInitializer.cs | Adds RequiresUnreferencedCode attribute to indicate trimming incompatibility |
| src/Grafana.OpenTelemetry.Base/Instrumentations/InstrumentationInitializer.cs | Refactors static array to dynamic method with runtime checks for SqlClient compatibility |
| src/Grafana.OpenTelemetry.Base/GrafanaOpenTelemetrySettings.cs | Updates collection initialization and optimizes array allocation patterns |
| src/Grafana.OpenTelemetry.Base/GrafanaOpenTelemetryEventSource.cs | Adds source generator support for JSON serialization in .NET |
src/Grafana.OpenTelemetry.Base/Instrumentations/InstrumentationInitializer.cs
Show resolved
Hide resolved
matt-hensley
approved these changes
Jul 16, 2025
This was referenced Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #97.
Changes
Address some native AoT warnings with .NET 8.
The only remaining warning is from the usage of
ReflectionHelper.CallStaticMethod().Need to update the documentation to state somewhere that SQL instrumentation is not enabled when using native AoT.
Merge requirement checklist
Unit tests added/updatedCHANGELOG.mdfile updated for non-trivial changesChanges in public API reviewed (if applicable)